admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete deprecated RTPSender constructor

Browse Source 
Bug: webrtc:11340
Change-Id: Id7ade3b15510e32b8bf4653b0e1652c275b58e88
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258789
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36549}
This commit is contained in:
Danil Chapovalov 2022-04-13 13:16:27 +02:00 committed by WebRTC LUCI CQ
parent 9289c0f714
commit 836d58408d
3 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/rtp_rtcp/source/rtp_sender.cc
View File

@ -155,12 +155,6 @@ double GetMaxPaddingSizeFactor(const FieldTrialsView* field_trials) {
} // namespace } // namespace
RTPSender::RTPSender(const RtpRtcpInterface::Configuration& config,
RtpPacketHistory* packet_history,
RtpPacketSender* packet_sender,
PacketSequencer*)
: RTPSender(config, packet_history, packet_sender) {}
RTPSender::RTPSender(const RtpRtcpInterface::Configuration& config, RTPSender::RTPSender(const RtpRtcpInterface::Configuration& config,
RtpPacketHistory* packet_history, RtpPacketHistory* packet_history,
RtpPacketSender* packet_sender) RtpPacketSender* packet_sender)

9
modules/rtp_rtcp/source/rtp_sender.h
View File

@ -26,7 +26,6 @@
#include "modules/rtp_rtcp/include/rtp_header_extension_map.h" #include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
#include "modules/rtp_rtcp/include/rtp_packet_sender.h" #include "modules/rtp_rtcp/include/rtp_packet_sender.h"
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "modules/rtp_rtcp/source/packet_sequencer.h"
#include "modules/rtp_rtcp/source/rtp_packet_history.h" #include "modules/rtp_rtcp/source/rtp_packet_history.h"
#include "modules/rtp_rtcp/source/rtp_rtcp_config.h" #include "modules/rtp_rtcp/source/rtp_rtcp_config.h"
#include "modules/rtp_rtcp/source/rtp_rtcp_interface.h" #include "modules/rtp_rtcp/source/rtp_rtcp_interface.h"
@ -47,14 +46,6 @@ class RTPSender {
RTPSender(const RtpRtcpInterface::Configuration& config, RTPSender(const RtpRtcpInterface::Configuration& config,
RtpPacketHistory* packet_history, RtpPacketHistory* packet_history,
RtpPacketSender* packet_sender); RtpPacketSender* packet_sender);
ABSL_DEPRECATED("bugs.webrtc.org/11340")
RTPSender(const RtpRtcpInterface::Configuration& config,
RtpPacketHistory* packet_history,
RtpPacketSender* packet_sender,
PacketSequencer* packet_sequencer);
RTPSender() = delete;
RTPSender(const RTPSender&) = delete; RTPSender(const RTPSender&) = delete;
RTPSender& operator=(const RTPSender&) = delete; RTPSender& operator=(const RTPSender&) = delete;

2
modules/rtp_rtcp/source/rtp_sender_unittest.cc
View File

@ -170,7 +170,7 @@ class RtpSenderTest : public ::testing::Test {
/*require_marker_before_media_padding=*/!config.audio, /*require_marker_before_media_padding=*/!config.audio,
clock_); clock_);
rtp_sender_ = std::make_unique<RTPSender>(config, packet_history_.get(), rtp_sender_ = std::make_unique<RTPSender>(config, packet_history_.get(),
config.paced_sender, nullptr); config.paced_sender);
sequencer_->set_media_sequence_number(kSeqNum); sequencer_->set_media_sequence_number(kSeqNum);
rtp_sender_->SetTimestampOffset(0); rtp_sender_->SetTimestampOffset(0);
} }