admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable encoder frame drop for call tests and video quality tests

Browse Source 
It was accidentally disabled by
https://webrtc-review.googlesource.com/c/src/+/262244, resulting in
lots of unintended changes in performance tests.

Bug: webrtc:6883, webrtc:14075
Change-Id: Ie414f729ec2248f0eef99922e9704f4c4a0b1aa0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262813
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36931}
This commit is contained in:
Niels Möller 2022-05-19 15:54:13 +02:00 committed by WebRTC LUCI CQ
parent 6c81a42eb1
commit 8139cda2ec
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/encoder_settings.cc
View File

@ -123,6 +123,7 @@ void FillEncoderConfiguration(VideoCodecType codec_type,
configuration->video_stream_factory = configuration->video_stream_factory =
rtc::make_ref_counted<DefaultVideoStreamFactory>(); rtc::make_ref_counted<DefaultVideoStreamFactory>();
configuration->max_bitrate_bps = 0; configuration->max_bitrate_bps = 0;
configuration->frame_drop_enabled = true;
configuration->simulcast_layers = std::vector<VideoStream>(num_streams); configuration->simulcast_layers = std::vector<VideoStream>(num_streams);
for (size_t i = 0; i < num_streams; ++i) { for (size_t i = 0; i < num_streams; ++i) {
configuration->max_bitrate_bps += configuration->max_bitrate_bps +=

3
video/video_quality_test.cc
View File

@ -807,6 +807,9 @@ void VideoQualityTest::SetupVideo(Transport* send_transport,
video_encoder_configs_[video_idx].spatial_layers = video_encoder_configs_[video_idx].spatial_layers =
params_.ss[video_idx].spatial_layers; params_.ss[video_idx].spatial_layers;
video_encoder_configs_[video_idx].frame_drop_enabled = true;
decode_all_receive_streams = params_.ss[video_idx].selected_stream == decode_all_receive_streams = params_.ss[video_idx].selected_stream ==
params_.ss[video_idx].streams.size(); params_.ss[video_idx].streams.size();
absl::optional<int> decode_sub_stream; absl::optional<int> decode_sub_stream;