From 8139cda2ecaa8d3a5ec1859ddeefce0d45568d5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Thu, 19 May 2022 15:54:13 +0200 Subject: [PATCH] Enable encoder frame drop for call tests and video quality tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was accidentally disabled by https://webrtc-review.googlesource.com/c/src/+/262244, resulting in lots of unintended changes in performance tests. Bug: webrtc:6883, webrtc:14075 Change-Id: Ie414f729ec2248f0eef99922e9704f4c4a0b1aa0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262813 Commit-Queue: Niels Moller Reviewed-by: Mirko Bonadei Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/main@{#36931} --- test/encoder_settings.cc | 1 + video/video_quality_test.cc | 3 +++ 2 files changed, 4 insertions(+) diff --git a/test/encoder_settings.cc b/test/encoder_settings.cc index 09cefc8d77..6058aa9ed4 100644 --- a/test/encoder_settings.cc +++ b/test/encoder_settings.cc @@ -123,6 +123,7 @@ void FillEncoderConfiguration(VideoCodecType codec_type, configuration->video_stream_factory = rtc::make_ref_counted(); configuration->max_bitrate_bps = 0; + configuration->frame_drop_enabled = true; configuration->simulcast_layers = std::vector(num_streams); for (size_t i = 0; i < num_streams; ++i) { configuration->max_bitrate_bps += diff --git a/video/video_quality_test.cc b/video/video_quality_test.cc index 4501096379..b8a44e27ab 100644 --- a/video/video_quality_test.cc +++ b/video/video_quality_test.cc @@ -807,6 +807,9 @@ void VideoQualityTest::SetupVideo(Transport* send_transport, video_encoder_configs_[video_idx].spatial_layers = params_.ss[video_idx].spatial_layers; + + video_encoder_configs_[video_idx].frame_drop_enabled = true; + decode_all_receive_streams = params_.ss[video_idx].selected_stream == params_.ss[video_idx].streams.size(); absl::optional decode_sub_stream;