admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CallPerfTest tests

Browse Source 
iSAC has been removed, the tests now use Opus which requires min/max
bitrate to be set.

Bug: webrtc:14450
Change-Id: I872764b1ebb9115e314f146749fe710a7665ad62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284060
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38680}
This commit is contained in:
Alessio Bazzica 2022-11-18 11:52:19 +01:00 committed by WebRTC LUCI CQ
parent 858864dcb4
commit 7dc590e0b7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
call/call_perf_tests.cc
View File

@ -267,8 +267,11 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec,
AudioSendStream::Config audio_send_config(audio_send_transport.get());
audio_send_config.rtp.ssrc = kAudioSendSsrc;
// TODO(bugs.webrtc.org/14683): Let the tests fail with invalid config.
audio_send_config.send_codec_spec = AudioSendStream::Config::SendCodecSpec(
kAudioSendPayloadType, {"ISAC", 16000, 1});
kAudioSendPayloadType, {"OPUS", 48000, 2});
audio_send_config.min_bitrate_bps = 6000;
audio_send_config.max_bitrate_bps = 510000;
audio_send_config.encoder_factory = CreateBuiltinAudioEncoderFactory();
audio_send_stream = sender_call_->CreateAudioSendStream(audio_send_config);
@ -290,7 +293,7 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec,
audio_recv_config.sync_group = kSyncGroup;
audio_recv_config.decoder_factory = audio_decoder_factory_;
audio_recv_config.decoder_map = {
{kAudioSendPayloadType, {"ISAC", 16000, 1}}};
{kAudioSendPayloadType, {"OPUS", 48000, 2}}};
if (create_first == CreateOrder::kAudioFirst) {
audio_receive_stream =