From 7dc590e0b758d3f44a82a4afac99304880a3f221 Mon Sep 17 00:00:00 2001 From: Alessio Bazzica Date: Fri, 18 Nov 2022 11:52:19 +0100 Subject: [PATCH] Fix `CallPerfTest` tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit iSAC has been removed, the tests now use Opus which requires min/max bitrate to be set. Bug: webrtc:14450 Change-Id: I872764b1ebb9115e314f146749fe710a7665ad62 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284060 Reviewed-by: Erik Språng Reviewed-by: Mirko Bonadei Commit-Queue: Alessio Bazzica Cr-Commit-Position: refs/heads/main@{#38680} --- call/call_perf_tests.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/call/call_perf_tests.cc b/call/call_perf_tests.cc index 9379dce833..ac139af5e2 100644 --- a/call/call_perf_tests.cc +++ b/call/call_perf_tests.cc @@ -267,8 +267,11 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec, AudioSendStream::Config audio_send_config(audio_send_transport.get()); audio_send_config.rtp.ssrc = kAudioSendSsrc; + // TODO(bugs.webrtc.org/14683): Let the tests fail with invalid config. audio_send_config.send_codec_spec = AudioSendStream::Config::SendCodecSpec( - kAudioSendPayloadType, {"ISAC", 16000, 1}); + kAudioSendPayloadType, {"OPUS", 48000, 2}); + audio_send_config.min_bitrate_bps = 6000; + audio_send_config.max_bitrate_bps = 510000; audio_send_config.encoder_factory = CreateBuiltinAudioEncoderFactory(); audio_send_stream = sender_call_->CreateAudioSendStream(audio_send_config); @@ -290,7 +293,7 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec, audio_recv_config.sync_group = kSyncGroup; audio_recv_config.decoder_factory = audio_decoder_factory_; audio_recv_config.decoder_map = { - {kAudioSendPayloadType, {"ISAC", 16000, 1}}}; + {kAudioSendPayloadType, {"OPUS", 48000, 2}}}; if (create_first == CreateOrder::kAudioFirst) { audio_receive_stream =