admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Replace RTPHeader memset with assignment from a fresh object."

Browse Source 
This reverts commit 50686460caad4d13283c550df01690316e7cb934.

Reason for revert: breaking downstream

Original change's description:
> Replace RTPHeader memset with assignment from a fresh object.
> 
> Since RTPHeader contains std::string members, memset results in
> undefined behavior, with memory leaks being the best case.
> 
> Bug: chromium:945598
> Change-Id: I5c04e6b2fb08816fc036abfbb6ba7aaf19469687
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129720
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27282}

TBR=danilchap@webrtc.org,nisse@webrtc.org

Change-Id: Ifc69b6df7cd2ecd8d1b3dd5186e933ad12b53a8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:945598
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129722
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27285}
This commit is contained in:
Alessio Bazzica 2019-03-26 11:58:49 +00:00 committed by Commit Bot
parent 12ba3adcaf
commit 76ba7dbc4f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/rtp_rtcp/source/rtp_header_parser.cc
View File

@ -64,7 +64,7 @@ bool RtpHeaderParserImpl::Parse(const uint8_t* packet,
size_t length,
RTPHeader* header) const {
RtpUtility::RtpHeaderParser rtp_parser(packet, length);
*header = RTPHeader();
memset(header, 0, sizeof(*header));
RtpHeaderExtensionMap map;
{