From 76ba7dbc4f952c44a9e26bbc293d58997857ce18 Mon Sep 17 00:00:00 2001 From: Alessio Bazzica Date: Tue, 26 Mar 2019 11:58:49 +0000 Subject: [PATCH] Revert "Replace RTPHeader memset with assignment from a fresh object." This reverts commit 50686460caad4d13283c550df01690316e7cb934. Reason for revert: breaking downstream Original change's description: > Replace RTPHeader memset with assignment from a fresh object. > > Since RTPHeader contains std::string members, memset results in > undefined behavior, with memory leaks being the best case. > > Bug: chromium:945598 > Change-Id: I5c04e6b2fb08816fc036abfbb6ba7aaf19469687 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129720 > Reviewed-by: Danil Chapovalov > Commit-Queue: Niels Moller > Cr-Commit-Position: refs/heads/master@{#27282} TBR=danilchap@webrtc.org,nisse@webrtc.org Change-Id: Ifc69b6df7cd2ecd8d1b3dd5186e933ad12b53a8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:945598 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129722 Reviewed-by: Alessio Bazzica Commit-Queue: Alessio Bazzica Cr-Commit-Position: refs/heads/master@{#27285} --- modules/rtp_rtcp/source/rtp_header_parser.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/rtp_rtcp/source/rtp_header_parser.cc b/modules/rtp_rtcp/source/rtp_header_parser.cc index 65431d1397..1d937f80bd 100644 --- a/modules/rtp_rtcp/source/rtp_header_parser.cc +++ b/modules/rtp_rtcp/source/rtp_header_parser.cc @@ -64,7 +64,7 @@ bool RtpHeaderParserImpl::Parse(const uint8_t* packet, size_t length, RTPHeader* header) const { RtpUtility::RtpHeaderParser rtp_parser(packet, length); - *header = RTPHeader(); + memset(header, 0, sizeof(*header)); RtpHeaderExtensionMap map; {