admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make mixing test die earlier on failure instead of spamming errors

Browse Source 
This test currently takes 288 seconds to fail if output values are
wrong; there's no point to print the failure hundreds of times.
This change will exit the test early.

R=henrika@webrtc.org
BUG=623538
NOTRY=true

Review-Url: https://codereview.webrtc.org/2097363002
Cr-Commit-Position: refs/heads/master@{#13295}
This commit is contained in:
phoglund 2016-06-27 07:18:35 -07:00 committed by Commit bot
parent b52e81c054
commit 685440be2d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/voice_engine/test/auto_test/standard/mixing_test.cc
View File

@ -129,8 +129,8 @@ class MixingTest : public AfterInitializationFixture {
std::ostringstream trace_stream;
trace_stream << samples_read << " samples read";
SCOPED_TRACE(trace_stream.str());
EXPECT_LE(output_value, max_output_value);
EXPECT_GE(output_value, min_output_value);
ASSERT_LE(output_value, max_output_value);
ASSERT_GE(output_value, min_output_value);
}
// Ensure we've at least recorded half as much file as the duration of the
// test. We have to use a relaxed tolerance here due to filesystem flakiness