From 685440be2dd3bcb996babfcd4ee31b8b71100436 Mon Sep 17 00:00:00 2001 From: phoglund Date: Mon, 27 Jun 2016 07:18:35 -0700 Subject: [PATCH] Make mixing test die earlier on failure instead of spamming errors This test currently takes 288 seconds to fail if output values are wrong; there's no point to print the failure hundreds of times. This change will exit the test early. R=henrika@webrtc.org BUG=623538 NOTRY=true Review-Url: https://codereview.webrtc.org/2097363002 Cr-Commit-Position: refs/heads/master@{#13295} --- webrtc/voice_engine/test/auto_test/standard/mixing_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webrtc/voice_engine/test/auto_test/standard/mixing_test.cc b/webrtc/voice_engine/test/auto_test/standard/mixing_test.cc index b7f7d560d7..fcee2f707b 100644 --- a/webrtc/voice_engine/test/auto_test/standard/mixing_test.cc +++ b/webrtc/voice_engine/test/auto_test/standard/mixing_test.cc @@ -129,8 +129,8 @@ class MixingTest : public AfterInitializationFixture { std::ostringstream trace_stream; trace_stream << samples_read << " samples read"; SCOPED_TRACE(trace_stream.str()); - EXPECT_LE(output_value, max_output_value); - EXPECT_GE(output_value, min_output_value); + ASSERT_LE(output_value, max_output_value); + ASSERT_GE(output_value, min_output_value); } // Ensure we've at least recorded half as much file as the duration of the // test. We have to use a relaxed tolerance here due to filesystem flakiness