admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Follow up CL to address clang-tidy suggestions minor issues.

Browse Source 
Original CL: https://webrtc-review.googlesource.com/c/src/+/130103

Bug: webrtc:10138
Change-Id: I3bd7459442c36fdb97f581e436a0f365126fb6ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130476
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#27396}
This commit is contained in:
Artem Titov 2019-04-01 14:43:38 +02:00 committed by Commit Bot
parent bdecb3cdbe
commit 612e179a28
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/scenario/network/network_emulation.cc
View File

@ -27,9 +27,6 @@ EmulatedIpPacket::EmulatedIpPacket(const rtc::SocketAddress& from,
to(to),
data(data),
arrival_time(arrival_time) {}
EmulatedIpPacket::~EmulatedIpPacket() = default;
EmulatedIpPacket::EmulatedIpPacket(EmulatedIpPacket&&) = default;
EmulatedIpPacket& EmulatedIpPacket::operator=(EmulatedIpPacket&&) = default;
void EmulatedNetworkNode::CreateRoute(
rtc::IPAddress receiver_ip,
@ -150,7 +147,7 @@ void EmulatedNetworkNode::RemoveReceiver(rtc::IPAddress dest_ip) {
}
EmulatedEndpoint::EmulatedEndpoint(uint64_t id,
rtc::IPAddress ip,
const rtc::IPAddress& ip,
bool is_enabled,
Clock* clock)
: id_(id),

8
test/scenario/network/network_emulation.h
View File

@ -44,13 +44,13 @@ struct EmulatedIpPacket {
const rtc::SocketAddress& to,
rtc::CopyOnWriteBuffer data,
Timestamp arrival_time);
~EmulatedIpPacket();
~EmulatedIpPacket() = default;
// This object is not copyable or assignable.
EmulatedIpPacket(const EmulatedIpPacket&) = delete;
EmulatedIpPacket& operator=(const EmulatedIpPacket&) = delete;
// This object is only moveable.
EmulatedIpPacket(EmulatedIpPacket&&);
EmulatedIpPacket& operator=(EmulatedIpPacket&&);
EmulatedIpPacket(EmulatedIpPacket&&) = default;
EmulatedIpPacket& operator=(EmulatedIpPacket&&) = default;
size_t size() const { return data.size(); }
const uint8_t* cdata() const { return data.cdata(); }
@ -126,7 +126,7 @@ class EmulatedNetworkNode : public EmulatedNetworkReceiverInterface {
class EmulatedEndpoint : public EmulatedNetworkReceiverInterface {
public:
EmulatedEndpoint(uint64_t id,
rtc::IPAddress ip,
const rtc::IPAddress& ip,
bool is_enabled,
Clock* clock);
~EmulatedEndpoint() override;