From 612e179a282656577bf5c6b6420370d67e0c0b4f Mon Sep 17 00:00:00 2001
From: Artem Titov <titovartem@webrtc.org>
Date: Mon, 1 Apr 2019 14:43:38 +0200
Subject: [PATCH] Follow up CL to address clang-tidy suggestions minor issues.

Original CL: https://webrtc-review.googlesource.com/c/src/+/130103

Bug: webrtc:10138
Change-Id: I3bd7459442c36fdb97f581e436a0f365126fb6ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130476
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#27396}
---
 test/scenario/network/network_emulation.cc | 5 +----
 test/scenario/network/network_emulation.h  | 8 ++++----
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/test/scenario/network/network_emulation.cc b/test/scenario/network/network_emulation.cc
index bcc015b5f5..4f706cfad3 100644
--- a/test/scenario/network/network_emulation.cc
+++ b/test/scenario/network/network_emulation.cc
@@ -27,9 +27,6 @@ EmulatedIpPacket::EmulatedIpPacket(const rtc::SocketAddress& from,
       to(to),
       data(data),
       arrival_time(arrival_time) {}
-EmulatedIpPacket::~EmulatedIpPacket() = default;
-EmulatedIpPacket::EmulatedIpPacket(EmulatedIpPacket&&) = default;
-EmulatedIpPacket& EmulatedIpPacket::operator=(EmulatedIpPacket&&) = default;
 
 void EmulatedNetworkNode::CreateRoute(
     rtc::IPAddress receiver_ip,
@@ -150,7 +147,7 @@ void EmulatedNetworkNode::RemoveReceiver(rtc::IPAddress dest_ip) {
 }
 
 EmulatedEndpoint::EmulatedEndpoint(uint64_t id,
-                                   rtc::IPAddress ip,
+                                   const rtc::IPAddress& ip,
                                    bool is_enabled,
                                    Clock* clock)
     : id_(id),
diff --git a/test/scenario/network/network_emulation.h b/test/scenario/network/network_emulation.h
index 836b56df42..674e39e10a 100644
--- a/test/scenario/network/network_emulation.h
+++ b/test/scenario/network/network_emulation.h
@@ -44,13 +44,13 @@ struct EmulatedIpPacket {
                    const rtc::SocketAddress& to,
                    rtc::CopyOnWriteBuffer data,
                    Timestamp arrival_time);
-  ~EmulatedIpPacket();
+  ~EmulatedIpPacket() = default;
   // This object is not copyable or assignable.
   EmulatedIpPacket(const EmulatedIpPacket&) = delete;
   EmulatedIpPacket& operator=(const EmulatedIpPacket&) = delete;
   // This object is only moveable.
-  EmulatedIpPacket(EmulatedIpPacket&&);
-  EmulatedIpPacket& operator=(EmulatedIpPacket&&);
+  EmulatedIpPacket(EmulatedIpPacket&&) = default;
+  EmulatedIpPacket& operator=(EmulatedIpPacket&&) = default;
 
   size_t size() const { return data.size(); }
   const uint8_t* cdata() const { return data.cdata(); }
@@ -126,7 +126,7 @@ class EmulatedNetworkNode : public EmulatedNetworkReceiverInterface {
 class EmulatedEndpoint : public EmulatedNetworkReceiverInterface {
  public:
   EmulatedEndpoint(uint64_t id,
-                   rtc::IPAddress ip,
+                   const rtc::IPAddress& ip,
                    bool is_enabled,
                    Clock* clock);
   ~EmulatedEndpoint() override;