admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make VideoDecoderFactory::CreateVideoDecoder private

Browse Source 
To ensure CreateVideoDecoder is only used as a fallback when Create is not implemented,
and thus make it safer to migrate VideoDecoderFactory implementations to Create.

Bug: webrtc:15791
Change-Id: Ifb15cf1d303348949ba51a3bb4c91b855a06627f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339841
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41777}
This commit is contained in:
Danil Chapovalov 2024-02-15 18:11:13 +01:00 committed by WebRTC LUCI CQ
parent 74a4038ead
commit 56d3cf0c6d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/video_codecs/video_decoder_factory.h
View File

@ -55,8 +55,9 @@ class RTC_EXPORT VideoDecoderFactory {
virtual std::unique_ptr<VideoDecoder> Create(const Environment& env,
const SdpVideoFormat& format);
// TODO: bugs.webrtc.org/15791 - Make private or delete when all callers are
// migrated to `Create`.
private:
// TODO: bugs.webrtc.org/15791 - Delete when all derived classes implement
// `Create`.
virtual std::unique_ptr<VideoDecoder> CreateVideoDecoder(
const SdpVideoFormat& format);
};