From 56d3cf0c6daa7d0de80c0d3fbf6de246b63ce003 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Thu, 15 Feb 2024 18:11:13 +0100 Subject: [PATCH] Make VideoDecoderFactory::CreateVideoDecoder private To ensure CreateVideoDecoder is only used as a fallback when Create is not implemented, and thus make it safer to migrate VideoDecoderFactory implementations to Create. Bug: webrtc:15791 Change-Id: Ifb15cf1d303348949ba51a3bb4c91b855a06627f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339841 Reviewed-by: Philip Eliasson Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#41777} --- api/video_codecs/video_decoder_factory.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/api/video_codecs/video_decoder_factory.h b/api/video_codecs/video_decoder_factory.h index 6048cb27fb..92a2697ca5 100644 --- a/api/video_codecs/video_decoder_factory.h +++ b/api/video_codecs/video_decoder_factory.h @@ -55,8 +55,9 @@ class RTC_EXPORT VideoDecoderFactory { virtual std::unique_ptr Create(const Environment& env, const SdpVideoFormat& format); - // TODO: bugs.webrtc.org/15791 - Make private or delete when all callers are - // migrated to `Create`. + private: + // TODO: bugs.webrtc.org/15791 - Delete when all derived classes implement + // `Create`. virtual std::unique_ptr CreateVideoDecoder( const SdpVideoFormat& format); };