admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase number of times a nack request can be sent from 10 to 100.

Browse Source 
If traffic policing is enforced by dropping packets, RTT can still be low.
If a packet is dropped that is needed to contninue decoding, it make sense that a nack request is sent until the packet is received, or a new key frame is requested. A key frame will be requested after 3s.
For now, this cl only increase the number of times a packet can be requested.

Bug: b/317178411
Change-Id: Iea75d36ed06f346af1dd4e55a9961d5eca45f519
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/356482
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42594}
This commit is contained in:
Per K 2024-07-05 11:23:30 +00:00 committed by WebRTC LUCI CQ
parent db65fda82f
commit 508e20f92b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/video_coding/nack_requester.cc
View File

@ -25,7 +25,9 @@ namespace {
constexpr int kMaxPacketAge = 10'000;
constexpr int kMaxNackPackets = 1000;
constexpr TimeDelta kDefaultRtt = TimeDelta::Millis(100);
constexpr int kMaxNackRetries = 10;
// Number of times a packet can be nacked before giving up. Nack is sent at most
// every RTT.
constexpr int kMaxNackRetries = 100;
constexpr int kMaxReorderedPackets = 128;
constexpr int kNumReorderingBuckets = 10;
constexpr TimeDelta kDefaultSendNackDelay = TimeDelta::Zero();