From 508e20f92b1aabb1a644ef71e6c960008fe471ed Mon Sep 17 00:00:00 2001 From: Per K Date: Fri, 5 Jul 2024 11:23:30 +0000 Subject: [PATCH] Increase number of times a nack request can be sent from 10 to 100. If traffic policing is enforced by dropping packets, RTT can still be low. If a packet is dropped that is needed to contninue decoding, it make sense that a nack request is sent until the packet is received, or a new key frame is requested. A key frame will be requested after 3s. For now, this cl only increase the number of times a packet can be requested. Bug: b/317178411 Change-Id: Iea75d36ed06f346af1dd4e55a9961d5eca45f519 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/356482 Reviewed-by: Philip Eliasson Commit-Queue: Per Kjellander Cr-Commit-Position: refs/heads/main@{#42594} --- modules/video_coding/nack_requester.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/video_coding/nack_requester.cc b/modules/video_coding/nack_requester.cc index b3e928d05e..ac7c421ccd 100644 --- a/modules/video_coding/nack_requester.cc +++ b/modules/video_coding/nack_requester.cc @@ -25,7 +25,9 @@ namespace { constexpr int kMaxPacketAge = 10'000; constexpr int kMaxNackPackets = 1000; constexpr TimeDelta kDefaultRtt = TimeDelta::Millis(100); -constexpr int kMaxNackRetries = 10; +// Number of times a packet can be nacked before giving up. Nack is sent at most +// every RTT. +constexpr int kMaxNackRetries = 100; constexpr int kMaxReorderedPackets = 128; constexpr int kNumReorderingBuckets = 10; constexpr TimeDelta kDefaultSendNackDelay = TimeDelta::Zero();