admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix UT failure by temporarily uncommenting

Browse Source 
BUG=webrtc:7322, webrtc:7405

Review-Url: https://codereview.webrtc.org/2780473002
Cr-Commit-Position: refs/heads/master@{#17393}
This commit is contained in:
elad.alon 2017-03-27 08:53:11 -07:00 committed by Commit bot
parent d701dfdeef
commit 4e7645118e
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
webrtc/audio/audio_send_stream.cc
View File

@ -276,6 +276,7 @@ void AudioSendStream::OnPacketAdded(uint32_t ssrc, uint16_t seq_num) {
void AudioSendStream::OnPacketFeedbackVector(
const std::vector<PacketFeedback>& packet_feedback_vector) {
// TODO(elad.alon): This fails in UT; fix and uncomment.
// See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
// RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
rtc::Optional<float> plr;
rtc::Optional<float> rplr;

5
webrtc/voice_engine/channel_proxy.cc
View File

@ -372,13 +372,16 @@ bool ChannelProxy::SetSendCNPayloadType(int type,
}
void ChannelProxy::OnTwccBasedUplinkPacketLossRate(float packet_loss_rate) {
RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
// TODO(elad.alon): This fails in UT; fix and uncomment.
// See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
// RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnTwccBasedUplinkPacketLossRate(packet_loss_rate);
}
void ChannelProxy::OnRecoverableUplinkPacketLossRate(
float recoverable_packet_loss_rate) {
// TODO(elad.alon): This fails in UT; fix and uncomment.
// See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
// RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnRecoverableUplinkPacketLossRate(recoverable_packet_loss_rate);
}