From 4e7645118ed4dcd43b2856f85720e72cd248771c Mon Sep 17 00:00:00 2001 From: "elad.alon" Date: Mon, 27 Mar 2017 08:53:11 -0700 Subject: [PATCH] Fix UT failure by temporarily uncommenting BUG=webrtc:7322, webrtc:7405 Review-Url: https://codereview.webrtc.org/2780473002 Cr-Commit-Position: refs/heads/master@{#17393} --- webrtc/audio/audio_send_stream.cc | 1 + webrtc/voice_engine/channel_proxy.cc | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/webrtc/audio/audio_send_stream.cc b/webrtc/audio/audio_send_stream.cc index 6f72998172..856155bf7f 100644 --- a/webrtc/audio/audio_send_stream.cc +++ b/webrtc/audio/audio_send_stream.cc @@ -276,6 +276,7 @@ void AudioSendStream::OnPacketAdded(uint32_t ssrc, uint16_t seq_num) { void AudioSendStream::OnPacketFeedbackVector( const std::vector& packet_feedback_vector) { // TODO(elad.alon): This fails in UT; fix and uncomment. + // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405 // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); rtc::Optional plr; rtc::Optional rplr; diff --git a/webrtc/voice_engine/channel_proxy.cc b/webrtc/voice_engine/channel_proxy.cc index 64af08b420..de982977ca 100644 --- a/webrtc/voice_engine/channel_proxy.cc +++ b/webrtc/voice_engine/channel_proxy.cc @@ -372,13 +372,16 @@ bool ChannelProxy::SetSendCNPayloadType(int type, } void ChannelProxy::OnTwccBasedUplinkPacketLossRate(float packet_loss_rate) { - RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); + // TODO(elad.alon): This fails in UT; fix and uncomment. + // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405 + // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); channel()->OnTwccBasedUplinkPacketLossRate(packet_loss_rate); } void ChannelProxy::OnRecoverableUplinkPacketLossRate( float recoverable_packet_loss_rate) { // TODO(elad.alon): This fails in UT; fix and uncomment. + // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405 // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); channel()->OnRecoverableUplinkPacketLossRate(recoverable_packet_loss_rate); }