admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Export rtc::Socket for Chromium component builds

Browse Source 
As of https://webrtc-review.googlesource.com/c/src/+/332200, socket is
no longer pure virtual and needs to be exported for Chromium component
build tests.

Bug: webrtc:15368
Change-Id: I3d2fcd329bc859d07106ae740eb2791eccaea1f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334060
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41504}
This commit is contained in:
Per K 2024-01-11 09:50:32 +01:00 committed by WebRTC LUCI CQ
parent 844225a76a
commit 4e3b101bc9
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
rtc_base/BUILD.gn
View File

@ -1109,6 +1109,7 @@ rtc_library("socket") {
":macromagic", ":macromagic",
":socket_address", ":socket_address",
"../api/units:timestamp", "../api/units:timestamp",
"system:rtc_export",
"third_party/sigslot", "third_party/sigslot",
] ]
if (is_win) { if (is_win) {

3
rtc_base/socket.h
View File

@ -30,6 +30,7 @@
#include "api/units/timestamp.h" #include "api/units/timestamp.h"
#include "rtc_base/buffer.h" #include "rtc_base/buffer.h"
#include "rtc_base/socket_address.h" #include "rtc_base/socket_address.h"
#include "rtc_base/system/rtc_export.h"
#include "rtc_base/third_party/sigslot/sigslot.h" #include "rtc_base/third_party/sigslot/sigslot.h"
// Rather than converting errors into a private namespace, // Rather than converting errors into a private namespace,
@ -82,7 +83,7 @@ inline bool IsBlockingError(int e) {
// General interface for the socket implementations of various networks. The // General interface for the socket implementations of various networks. The
// methods match those of normal UNIX sockets very closely. // methods match those of normal UNIX sockets very closely.
class Socket { class RTC_EXPORT Socket {
public: public:
struct ReceiveBuffer { struct ReceiveBuffer {
ReceiveBuffer(rtc::Buffer& payload) : payload(payload) {} ReceiveBuffer(rtc::Buffer& payload) : payload(payload) {}