From 4e3b101bc99fe6a7f0410a809cc4f3395e04d27a Mon Sep 17 00:00:00 2001 From: Per K Date: Thu, 11 Jan 2024 09:50:32 +0100 Subject: [PATCH] Export rtc::Socket for Chromium component builds As of https://webrtc-review.googlesource.com/c/src/+/332200, socket is no longer pure virtual and needs to be exported for Chromium component build tests. Bug: webrtc:15368 Change-Id: I3d2fcd329bc859d07106ae740eb2791eccaea1f9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334060 Commit-Queue: Mirko Bonadei Reviewed-by: Mirko Bonadei Commit-Queue: Per Kjellander Auto-Submit: Per Kjellander Cr-Commit-Position: refs/heads/main@{#41504} --- rtc_base/BUILD.gn | 1 + rtc_base/socket.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn index 7acff4dad1..174f410699 100644 --- a/rtc_base/BUILD.gn +++ b/rtc_base/BUILD.gn @@ -1109,6 +1109,7 @@ rtc_library("socket") { ":macromagic", ":socket_address", "../api/units:timestamp", + "system:rtc_export", "third_party/sigslot", ] if (is_win) { diff --git a/rtc_base/socket.h b/rtc_base/socket.h index 0fd0613e81..fac75aca94 100644 --- a/rtc_base/socket.h +++ b/rtc_base/socket.h @@ -30,6 +30,7 @@ #include "api/units/timestamp.h" #include "rtc_base/buffer.h" #include "rtc_base/socket_address.h" +#include "rtc_base/system/rtc_export.h" #include "rtc_base/third_party/sigslot/sigslot.h" // Rather than converting errors into a private namespace, @@ -82,7 +83,7 @@ inline bool IsBlockingError(int e) { // General interface for the socket implementations of various networks. The // methods match those of normal UNIX sockets very closely. -class Socket { +class RTC_EXPORT Socket { public: struct ReceiveBuffer { ReceiveBuffer(rtc::Buffer& payload) : payload(payload) {}