admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add frames_in_flight metric to catch not delivered frames

Browse Source 
Add frames_in_flight metric into PC framework to catch frames that were
captured but weren't delivered to the other side. Right now they won't
be reported as dropped, because it's unclear were they dropped or will
they be delivered. So the new metric is introduced. The lower value is
better for it.

Bug: webrtc:10138
Change-Id: Ide26b362a6b862bd961793cb53293becd92cfaa8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148599
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28834}
This commit is contained in:
Artem Titov 2019-08-12 17:09:39 +02:00 committed by Commit Bot
parent 110a4de4e2
commit 4d207a3460
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc
View File

@ -627,6 +627,11 @@ void DefaultVideoQualityAnalyzer::ReportResults(
test::PrintResult("dropped_frames", "", test_case_name,
frame_counters.dropped, "count",
/*important=*/false);
test::PrintResult("frames_in_flight", "", test_case_name,
frame_counters.captured - frame_counters.rendered -
frame_counters.dropped,
"count",
/*important=*/false);
ReportResult("max_skipped", test_case_name, stats.skipped_between_rendered,
"count");
}