From 4d207a346062ab3fa1f9a5c65d4cfc059b4d82a7 Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Mon, 12 Aug 2019 17:09:39 +0200 Subject: [PATCH] Add frames_in_flight metric to catch not delivered frames Add frames_in_flight metric into PC framework to catch frames that were captured but weren't delivered to the other side. Right now they won't be reported as dropped, because it's unclear were they dropped or will they be delivered. So the new metric is introduced. The lower value is better for it. Bug: webrtc:10138 Change-Id: Ide26b362a6b862bd961793cb53293becd92cfaa8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148599 Reviewed-by: Ilya Nikolaevskiy Commit-Queue: Artem Titov Cr-Commit-Position: refs/heads/master@{#28834} --- test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc b/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc index 30d021bbeb..ca5e09ff90 100644 --- a/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc +++ b/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc @@ -627,6 +627,11 @@ void DefaultVideoQualityAnalyzer::ReportResults( test::PrintResult("dropped_frames", "", test_case_name, frame_counters.dropped, "count", /*important=*/false); + test::PrintResult("frames_in_flight", "", test_case_name, + frame_counters.captured - frame_counters.rendered - + frame_counters.dropped, + "count", + /*important=*/false); ReportResult("max_skipped", test_case_name, stats.skipped_between_rendered, "count"); }