admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Using safe casts of allocation limits in Call.

Browse Source 
Bug: None
Change-Id: I71d0e1f92bf820d117b354dd7701c9c719cc2c0a
Reviewed-on: https://webrtc-review.googlesource.com/61784
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22490}
This commit is contained in:
Sebastian Jansson 2018-03-14 14:29:45 +01:00 committed by Commit Bot
parent 8d8cb56f3e
commit 4a9b4d6332
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
call/call.cc
View File

@ -49,6 +49,7 @@
#include "rtc_base/constructormagic.h"
#include "rtc_base/location.h"
#include "rtc_base/logging.h"
#include "rtc_base/numerics/safe_conversions.h"
#include "rtc_base/numerics/safe_minmax.h"
#include "rtc_base/ptr_util.h"
#include "rtc_base/rate_limiter.h"
@ -1108,8 +1109,11 @@ void Call::OnTargetTransferRate(TargetTransferRate msg) {
void Call::OnAllocationLimitsChanged(uint32_t min_send_bitrate_bps,
uint32_t max_padding_bitrate_bps,
uint32_t total_bitrate_bps) {
// TODO(srte): We should not mix signed and unsigned types for bitrates.
transport_send_->SetAllocatedSendBitrateLimits(
min_send_bitrate_bps, max_padding_bitrate_bps, total_bitrate_bps);
rtc::dchecked_cast<int>(min_send_bitrate_bps),
rtc::dchecked_cast<int>(max_padding_bitrate_bps),
rtc::dchecked_cast<int>(total_bitrate_bps));
rtc::CritScope lock(&bitrate_crit_);
min_allocated_send_bitrate_bps_ = min_send_bitrate_bps;
configured_max_padding_bitrate_bps_ = max_padding_bitrate_bps;