From 4a9b4d6332f596867d2a8fb34ff5b4befb9848eb Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Wed, 14 Mar 2018 14:29:45 +0100 Subject: [PATCH] Using safe casts of allocation limits in Call. Bug: None Change-Id: I71d0e1f92bf820d117b354dd7701c9c719cc2c0a Reviewed-on: https://webrtc-review.googlesource.com/61784 Commit-Queue: Sebastian Jansson Reviewed-by: Niels Moller Cr-Commit-Position: refs/heads/master@{#22490} --- call/call.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/call/call.cc b/call/call.cc index b3f3978ae4..79a59137a2 100644 --- a/call/call.cc +++ b/call/call.cc @@ -49,6 +49,7 @@ #include "rtc_base/constructormagic.h" #include "rtc_base/location.h" #include "rtc_base/logging.h" +#include "rtc_base/numerics/safe_conversions.h" #include "rtc_base/numerics/safe_minmax.h" #include "rtc_base/ptr_util.h" #include "rtc_base/rate_limiter.h" @@ -1108,8 +1109,11 @@ void Call::OnTargetTransferRate(TargetTransferRate msg) { void Call::OnAllocationLimitsChanged(uint32_t min_send_bitrate_bps, uint32_t max_padding_bitrate_bps, uint32_t total_bitrate_bps) { + // TODO(srte): We should not mix signed and unsigned types for bitrates. transport_send_->SetAllocatedSendBitrateLimits( - min_send_bitrate_bps, max_padding_bitrate_bps, total_bitrate_bps); + rtc::dchecked_cast(min_send_bitrate_bps), + rtc::dchecked_cast(max_padding_bitrate_bps), + rtc::dchecked_cast(total_bitrate_bps)); rtc::CritScope lock(&bitrate_crit_); min_allocated_send_bitrate_bps_ = min_send_bitrate_bps; configured_max_padding_bitrate_bps_ = max_padding_bitrate_bps;