admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add TODO in the Opus encoder where the application param is set

Browse Source 
Bug: webrtc:376071290
Change-Id: Idd9017435bab9f8b53771c0dd642fd4ce3db048e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366981
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43323}
This commit is contained in:
Alessio Bazzica 2024-10-29 12:12:31 +01:00 committed by WebRTC LUCI CQ
parent e8c8218f1b
commit 4a482a2160
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/audio_coding/codecs/opus/audio_encoder_opus.cc
View File

@ -245,6 +245,7 @@ std::optional<AudioEncoderOpusConfig> AudioEncoderOpusImpl::SdpToConfig(
config.bitrate_bps =
CalculateBitrate(config.max_playback_rate_hz, config.num_channels,
GetFormatParameter(format, "maxaveragebitrate"));
// TODO: https://issues.webrtc.org/376071290 - Use `contentHint` if available.
config.application = config.num_channels == 1
? AudioEncoderOpusConfig::ApplicationMode::kVoip
: AudioEncoderOpusConfig::ApplicationMode::kAudio;