From 4a482a2160e2e1aa3ec2858d8b6351d147a380ec Mon Sep 17 00:00:00 2001 From: Alessio Bazzica Date: Tue, 29 Oct 2024 12:12:31 +0100 Subject: [PATCH] Add TODO in the Opus encoder where the application param is set Bug: webrtc:376071290 Change-Id: Idd9017435bab9f8b53771c0dd642fd4ce3db048e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366981 Reviewed-by: Henrik Lundin Commit-Queue: Alessio Bazzica Cr-Commit-Position: refs/heads/main@{#43323} --- modules/audio_coding/codecs/opus/audio_encoder_opus.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/audio_coding/codecs/opus/audio_encoder_opus.cc b/modules/audio_coding/codecs/opus/audio_encoder_opus.cc index 288ee84a4c..3fb926ab34 100644 --- a/modules/audio_coding/codecs/opus/audio_encoder_opus.cc +++ b/modules/audio_coding/codecs/opus/audio_encoder_opus.cc @@ -245,6 +245,7 @@ std::optional AudioEncoderOpusImpl::SdpToConfig( config.bitrate_bps = CalculateBitrate(config.max_playback_rate_hz, config.num_channels, GetFormatParameter(format, "maxaveragebitrate")); + // TODO: https://issues.webrtc.org/376071290 - Use `contentHint` if available. config.application = config.num_channels == 1 ? AudioEncoderOpusConfig::ApplicationMode::kVoip : AudioEncoderOpusConfig::ApplicationMode::kAudio;