admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

openssl_stream_adapter: improve ssl handshake error logging

Browse Source 
BUG=webrtc:11817

Change-Id: Ia8a04779c028bd8071012211e4ac1cb1c424e759
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180621
Reviewed-by: Taylor <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#31861}
This commit is contained in:
Philipp Hancke 2020-08-04 11:40:25 +02:00 committed by Commit Bot
parent 0031b27671
commit 491fa44ed9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rtc_base/openssl_stream_adapter.cc
View File

@ -881,12 +881,13 @@ int OpenSSLStreamAdapter::ContinueSSL() {
case SSL_ERROR_ZERO_RETURN: case SSL_ERROR_ZERO_RETURN:
default: default:
RTC_LOG(LS_VERBOSE) << " -- error " << code;
SSLHandshakeError ssl_handshake_err = SSLHandshakeError::UNKNOWN; SSLHandshakeError ssl_handshake_err = SSLHandshakeError::UNKNOWN;
int err_code = ERR_peek_last_error(); int err_code = ERR_peek_last_error();
if (err_code != 0 && ERR_GET_REASON(err_code) == SSL_R_NO_SHARED_CIPHER) { if (err_code != 0 && ERR_GET_REASON(err_code) == SSL_R_NO_SHARED_CIPHER) {
ssl_handshake_err = SSLHandshakeError::INCOMPATIBLE_CIPHERSUITE; ssl_handshake_err = SSLHandshakeError::INCOMPATIBLE_CIPHERSUITE;
} }
RTC_LOG(LS_VERBOSE) << " -- error " << code << ", " << err_code << ", "
<< ERR_GET_REASON(err_code);
SignalSSLHandshakeError(ssl_handshake_err); SignalSSLHandshakeError(ssl_handshake_err);
return (ssl_error != 0) ? ssl_error : -1; return (ssl_error != 0) ? ssl_error : -1;
} }