From 491fa44ed907da0ec5c9ea6dc7ffb5119218b35c Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Tue, 4 Aug 2020 11:40:25 +0200 Subject: [PATCH] openssl_stream_adapter: improve ssl handshake error logging BUG=webrtc:11817 Change-Id: Ia8a04779c028bd8071012211e4ac1cb1c424e759 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180621 Reviewed-by: Taylor Reviewed-by: Harald Alvestrand Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/master@{#31861} --- rtc_base/openssl_stream_adapter.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rtc_base/openssl_stream_adapter.cc b/rtc_base/openssl_stream_adapter.cc index 7f4b79a53a..cd7f8025c7 100644 --- a/rtc_base/openssl_stream_adapter.cc +++ b/rtc_base/openssl_stream_adapter.cc @@ -881,12 +881,13 @@ int OpenSSLStreamAdapter::ContinueSSL() { case SSL_ERROR_ZERO_RETURN: default: - RTC_LOG(LS_VERBOSE) << " -- error " << code; SSLHandshakeError ssl_handshake_err = SSLHandshakeError::UNKNOWN; int err_code = ERR_peek_last_error(); if (err_code != 0 && ERR_GET_REASON(err_code) == SSL_R_NO_SHARED_CIPHER) { ssl_handshake_err = SSLHandshakeError::INCOMPATIBLE_CIPHERSUITE; } + RTC_LOG(LS_VERBOSE) << " -- error " << code << ", " << err_code << ", " + << ERR_GET_REASON(err_code); SignalSSLHandshakeError(ssl_handshake_err); return (ssl_error != 0) ? ssl_error : -1; }