admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Re-enable absl FailureSignalHandler in tests."

Browse Source 
This reverts commit 46e9629dda1de4315b5106741cc7072b4e01548c.

Reason for revert: Speculative revert.

Original change's description:
> Re-enable absl FailureSignalHandler in tests.
> 
> It was not the cause of the SIGSEGV on iossim, so it is fine to
> re-enable it.
> 
> TBR: titovartem@webrtc.org
> Bug: None
> Change-Id: I593a010f83f1a0df6b3419dd4f925380210844c9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175105
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Reviewed-by: Markus Handell <handellm@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31277}

TBR=mbonadei@webrtc.org,titovartem@webrtc.org,handellm@webrtc.org

Change-Id: I5e8456ea2918f740428517ee7eb5c561cb016652
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175112
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31280}
This commit is contained in:
Mirko Bonadei 2020-05-15 15:54:25 +00:00 committed by Commit Bot
parent cf6544aef7
commit 4515a55eed
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/test_main.cc
View File

@ -16,10 +16,11 @@
int main(int argc, char* argv[]) {
// Initialize the symbolizer to get a human-readable stack trace
absl::InitializeSymbolizer(argv[0]);
// TODO(crbug.com/1050976): Breaks iossim tests, re-enable when fixed.
// absl::InitializeSymbolizer(argv[0]);
absl::FailureSignalHandlerOptions options;
absl::InstallFailureSignalHandler(options);
// absl::FailureSignalHandlerOptions options;
// absl::InstallFailureSignalHandler(options);
std::unique_ptr<webrtc::TestMain> main = webrtc::TestMain::Create();
int err_code = main->Init(&argc, argv);