From 4515a55eed39d5d3440be2420cfcebd96576a43d Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 15 May 2020 15:54:25 +0000 Subject: [PATCH] Revert "Re-enable absl FailureSignalHandler in tests." This reverts commit 46e9629dda1de4315b5106741cc7072b4e01548c. Reason for revert: Speculative revert. Original change's description: > Re-enable absl FailureSignalHandler in tests. > > It was not the cause of the SIGSEGV on iossim, so it is fine to > re-enable it. > > TBR: titovartem@webrtc.org > Bug: None > Change-Id: I593a010f83f1a0df6b3419dd4f925380210844c9 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175105 > Commit-Queue: Mirko Bonadei > Reviewed-by: Artem Titov > Reviewed-by: Markus Handell > Cr-Commit-Position: refs/heads/master@{#31277} TBR=mbonadei@webrtc.org,titovartem@webrtc.org,handellm@webrtc.org Change-Id: I5e8456ea2918f740428517ee7eb5c561cb016652 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175112 Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#31280} --- test/test_main.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/test_main.cc b/test/test_main.cc index 5046979548..8555d5e6da 100644 --- a/test/test_main.cc +++ b/test/test_main.cc @@ -16,10 +16,11 @@ int main(int argc, char* argv[]) { // Initialize the symbolizer to get a human-readable stack trace - absl::InitializeSymbolizer(argv[0]); + // TODO(crbug.com/1050976): Breaks iossim tests, re-enable when fixed. + // absl::InitializeSymbolizer(argv[0]); - absl::FailureSignalHandlerOptions options; - absl::InstallFailureSignalHandler(options); + // absl::FailureSignalHandlerOptions options; + // absl::InstallFailureSignalHandler(options); std::unique_ptr main = webrtc::TestMain::Create(); int err_code = main->Init(&argc, argv);