admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disabling flaky complexity tests for the audio processing module.

Browse Source 
The complexity test for the audio processing module have long proven
to give false alarms of complexity regressions for which no related
changes can be identified. Attempts to address that has improved the
that, but the tests do still give false alarms.

This CL deactivates the complexity tests until a better way of
testing this is available.

BUG=chromium:713507, webrtc:5846,webrtc:6685,webrtc:7712

Review-Url: https://codereview.webrtc.org/2897403006
Cr-Commit-Position: refs/heads/master@{#18879}
This commit is contained in:
peah 2017-07-03 09:11:22 -07:00 committed by Commit Bot
parent 7ab7fd66c4
commit 4235d78b57
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
View File

@ -713,7 +713,8 @@ const float CallSimulator::kRenderInputFloatLevel = 0.5f;
const float CallSimulator::kCaptureInputFloatLevel = 0.03125f;
} // anonymous namespace
TEST_P(CallSimulator, ApiCallDurationTest) {
// TODO(peah): Reactivate once issue 7712 has been resolved.
TEST_P(CallSimulator, DISABLED_ApiCallDurationTest) {
// Run test and verify that it did not time out.
EXPECT_EQ(kEventSignaled, Run());
}

9
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc
View File

@ -187,7 +187,8 @@ void RunTogetherWithApm(std::string test_description,
} // namespace
TEST(LevelControllerPerformanceTest, StandaloneProcessing) {
// TODO(peah): Reactivate once issue 7712 has been resolved.
TEST(LevelControllerPerformanceTest, DISABLED_StandaloneProcessing) {
int sample_rates_to_test[] = {
AudioProcessing::kSampleRate8kHz, AudioProcessing::kSampleRate16kHz,
AudioProcessing::kSampleRate32kHz, AudioProcessing::kSampleRate48kHz};
@ -219,8 +220,9 @@ void TestSomeSampleRatesWithApm(const std::string& test_name,
use_mobile_agc, include_default_apm_processing);
}
// TODO(peah): Reactivate once issue 7712 has been resolved.
#if !defined(WEBRTC_ANDROID)
TEST(LevelControllerPerformanceTest, ProcessingViaApm) {
TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) {
#else
TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) {
#endif
@ -228,8 +230,9 @@ TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) {
TestSomeSampleRatesWithApm("SimpleLevelControlViaApm", false, false);
}
// TODO(peah): Reactivate once issue 7712 has been resolved.
#if !defined(WEBRTC_ANDROID)
TEST(LevelControllerPerformanceTest, InteractionWithDefaultApm) {
TEST(LevelControllerPerformanceTest, DISABLED_InteractionWithDefaultApm) {
#else
TEST(LevelControllerPerformanceTest, DISABLED_InteractionWithDefaultApm) {
#endif