From 4235d78b574aa2923b2e01a9ab35873544b33dfe Mon Sep 17 00:00:00 2001 From: peah Date: Mon, 3 Jul 2017 09:11:22 -0700 Subject: [PATCH] Disabling flaky complexity tests for the audio processing module. The complexity test for the audio processing module have long proven to give false alarms of complexity regressions for which no related changes can be identified. Attempts to address that has improved the that, but the tests do still give false alarms. This CL deactivates the complexity tests until a better way of testing this is available. BUG=chromium:713507, webrtc:5846,webrtc:6685,webrtc:7712 Review-Url: https://codereview.webrtc.org/2897403006 Cr-Commit-Position: refs/heads/master@{#18879} --- .../audio_processing_performance_unittest.cc | 3 ++- .../level_controller_complexity_unittest.cc | 9 ++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc b/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc index bf3d5a84d7..26d30d8c48 100644 --- a/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc +++ b/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc @@ -713,7 +713,8 @@ const float CallSimulator::kRenderInputFloatLevel = 0.5f; const float CallSimulator::kCaptureInputFloatLevel = 0.03125f; } // anonymous namespace -TEST_P(CallSimulator, ApiCallDurationTest) { +// TODO(peah): Reactivate once issue 7712 has been resolved. +TEST_P(CallSimulator, DISABLED_ApiCallDurationTest) { // Run test and verify that it did not time out. EXPECT_EQ(kEventSignaled, Run()); } diff --git a/webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc b/webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc index 6d12a0e2b1..a530d8d4d2 100644 --- a/webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc +++ b/webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc @@ -187,7 +187,8 @@ void RunTogetherWithApm(std::string test_description, } // namespace -TEST(LevelControllerPerformanceTest, StandaloneProcessing) { +// TODO(peah): Reactivate once issue 7712 has been resolved. +TEST(LevelControllerPerformanceTest, DISABLED_StandaloneProcessing) { int sample_rates_to_test[] = { AudioProcessing::kSampleRate8kHz, AudioProcessing::kSampleRate16kHz, AudioProcessing::kSampleRate32kHz, AudioProcessing::kSampleRate48kHz}; @@ -219,8 +220,9 @@ void TestSomeSampleRatesWithApm(const std::string& test_name, use_mobile_agc, include_default_apm_processing); } +// TODO(peah): Reactivate once issue 7712 has been resolved. #if !defined(WEBRTC_ANDROID) -TEST(LevelControllerPerformanceTest, ProcessingViaApm) { +TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) { #else TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) { #endif @@ -228,8 +230,9 @@ TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) { TestSomeSampleRatesWithApm("SimpleLevelControlViaApm", false, false); } +// TODO(peah): Reactivate once issue 7712 has been resolved. #if !defined(WEBRTC_ANDROID) -TEST(LevelControllerPerformanceTest, InteractionWithDefaultApm) { +TEST(LevelControllerPerformanceTest, DISABLED_InteractionWithDefaultApm) { #else TEST(LevelControllerPerformanceTest, DISABLED_InteractionWithDefaultApm) { #endif