admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused parameter from CopySocketInformationToPacketInfo

Browse Source 
Bug: webrtc:370878648
Change-Id: Iae1b122ec9c4de3add8d4fb882b8b352a608e650
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364505
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43160}
This commit is contained in:
Dor Hen 2024-10-02 12:51:26 -07:00 committed by WebRTC LUCI CQ
parent eca11ca18b
commit 3e99f8c877
4 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
rtc_base/async_packet_socket.cc
View File

@ -64,7 +64,6 @@ void AsyncPacketSocket::NotifyPacketReceived(
void CopySocketInformationToPacketInfo(size_t packet_size_bytes, void CopySocketInformationToPacketInfo(size_t packet_size_bytes,
const AsyncPacketSocket& socket_from, const AsyncPacketSocket& socket_from,
bool is_connectionless,
rtc::PacketInfo* info) { rtc::PacketInfo* info) {
info->packet_size_bytes = packet_size_bytes; info->packet_size_bytes = packet_size_bytes;
info->ip_overhead_bytes = socket_from.GetLocalAddress().ipaddr().overhead(); info->ip_overhead_bytes = socket_from.GetLocalAddress().ipaddr().overhead();

1
rtc_base/async_packet_socket.h
View File

@ -191,7 +191,6 @@ class RTC_EXPORT AsyncListenSocket : public sigslot::has_slots<> {
void CopySocketInformationToPacketInfo(size_t packet_size_bytes, void CopySocketInformationToPacketInfo(size_t packet_size_bytes,
const AsyncPacketSocket& socket_from, const AsyncPacketSocket& socket_from,
bool is_connectionless,
rtc::PacketInfo* info); rtc::PacketInfo* info);
} // namespace rtc } // namespace rtc

2
rtc_base/async_tcp_socket.cc
View File

@ -280,7 +280,7 @@ int AsyncTCPSocket::Send(const void* pv,
rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(), rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(),
options.info_signaled_after_sent); options.info_signaled_after_sent);
CopySocketInformationToPacketInfo(cb, *this, false, &sent_packet.info); CopySocketInformationToPacketInfo(cb, *this, &sent_packet.info);
SignalSentPacket(this, sent_packet); SignalSentPacket(this, sent_packet);
// We claim to have sent the whole thing, even if we only sent partial // We claim to have sent the whole thing, even if we only sent partial

4
rtc_base/async_udp_socket.cc
View File

@ -60,7 +60,7 @@ int AsyncUDPSocket::Send(const void* pv,
const rtc::PacketOptions& options) { const rtc::PacketOptions& options) {
rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(), rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(),
options.info_signaled_after_sent); options.info_signaled_after_sent);
CopySocketInformationToPacketInfo(cb, *this, false, &sent_packet.info); CopySocketInformationToPacketInfo(cb, *this, &sent_packet.info);
int ret = socket_->Send(pv, cb); int ret = socket_->Send(pv, cb);
SignalSentPacket(this, sent_packet); SignalSentPacket(this, sent_packet);
return ret; return ret;
@ -72,7 +72,7 @@ int AsyncUDPSocket::SendTo(const void* pv,
const rtc::PacketOptions& options) { const rtc::PacketOptions& options) {
rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(), rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(),
options.info_signaled_after_sent); options.info_signaled_after_sent);
CopySocketInformationToPacketInfo(cb, *this, true, &sent_packet.info); CopySocketInformationToPacketInfo(cb, *this, &sent_packet.info);
int ret = socket_->SendTo(pv, cb, addr); int ret = socket_->SendTo(pv, cb, addr);
SignalSentPacket(this, sent_packet); SignalSentPacket(this, sent_packet);
return ret; return ret;