From 3e99f8c877705b2dc7d708a16511804059e31346 Mon Sep 17 00:00:00 2001 From: Dor Hen Date: Wed, 2 Oct 2024 12:51:26 -0700 Subject: [PATCH] Remove unused parameter from CopySocketInformationToPacketInfo Bug: webrtc:370878648 Change-Id: Iae1b122ec9c4de3add8d4fb882b8b352a608e650 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364505 Reviewed-by: Harald Alvestrand Commit-Queue: Danil Chapovalov Reviewed-by: Mirko Bonadei Reviewed-by: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#43160} --- rtc_base/async_packet_socket.cc | 1 - rtc_base/async_packet_socket.h | 1 - rtc_base/async_tcp_socket.cc | 2 +- rtc_base/async_udp_socket.cc | 4 ++-- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/rtc_base/async_packet_socket.cc b/rtc_base/async_packet_socket.cc index e00bd03e3b..bc5b3d841a 100644 --- a/rtc_base/async_packet_socket.cc +++ b/rtc_base/async_packet_socket.cc @@ -64,7 +64,6 @@ void AsyncPacketSocket::NotifyPacketReceived( void CopySocketInformationToPacketInfo(size_t packet_size_bytes, const AsyncPacketSocket& socket_from, - bool is_connectionless, rtc::PacketInfo* info) { info->packet_size_bytes = packet_size_bytes; info->ip_overhead_bytes = socket_from.GetLocalAddress().ipaddr().overhead(); diff --git a/rtc_base/async_packet_socket.h b/rtc_base/async_packet_socket.h index 792a49c218..78841526e3 100644 --- a/rtc_base/async_packet_socket.h +++ b/rtc_base/async_packet_socket.h @@ -191,7 +191,6 @@ class RTC_EXPORT AsyncListenSocket : public sigslot::has_slots<> { void CopySocketInformationToPacketInfo(size_t packet_size_bytes, const AsyncPacketSocket& socket_from, - bool is_connectionless, rtc::PacketInfo* info); } // namespace rtc diff --git a/rtc_base/async_tcp_socket.cc b/rtc_base/async_tcp_socket.cc index 2924340c16..6e87689959 100644 --- a/rtc_base/async_tcp_socket.cc +++ b/rtc_base/async_tcp_socket.cc @@ -280,7 +280,7 @@ int AsyncTCPSocket::Send(const void* pv, rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(), options.info_signaled_after_sent); - CopySocketInformationToPacketInfo(cb, *this, false, &sent_packet.info); + CopySocketInformationToPacketInfo(cb, *this, &sent_packet.info); SignalSentPacket(this, sent_packet); // We claim to have sent the whole thing, even if we only sent partial diff --git a/rtc_base/async_udp_socket.cc b/rtc_base/async_udp_socket.cc index f6e2c515ce..8d8d7c95de 100644 --- a/rtc_base/async_udp_socket.cc +++ b/rtc_base/async_udp_socket.cc @@ -60,7 +60,7 @@ int AsyncUDPSocket::Send(const void* pv, const rtc::PacketOptions& options) { rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(), options.info_signaled_after_sent); - CopySocketInformationToPacketInfo(cb, *this, false, &sent_packet.info); + CopySocketInformationToPacketInfo(cb, *this, &sent_packet.info); int ret = socket_->Send(pv, cb); SignalSentPacket(this, sent_packet); return ret; @@ -72,7 +72,7 @@ int AsyncUDPSocket::SendTo(const void* pv, const rtc::PacketOptions& options) { rtc::SentPacket sent_packet(options.packet_id, rtc::TimeMillis(), options.info_signaled_after_sent); - CopySocketInformationToPacketInfo(cb, *this, true, &sent_packet.info); + CopySocketInformationToPacketInfo(cb, *this, &sent_packet.info); int ret = socket_->SendTo(pv, cb, addr); SignalSentPacket(this, sent_packet); return ret;