admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable rtc_strict_field_trials DCHECKs on most of the bots.

Browse Source 
This will allow to stop CLs on CQ in case the CL is adding or removing
a field trial without updating the field trial registry.

This only affects debug and release bots but not pure_release bots
since they are used for performance tests.

Bug: webrtc:14154
Change-Id: Iab277fd4791b6f0cfb5304fd4e39a8519ea71198
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321880
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40877}
This commit is contained in:
Mirko Bonadei 2023-10-05 13:38:51 +00:00 committed by WebRTC LUCI CQ
parent ee0270b67c
commit 3e560c6fb1
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools_webrtc/mb/mb_config.pyl
View File

@ -397,10 +397,10 @@
'gn_args': 'is_debug=true', 'gn_args': 'is_debug=true',
}, },
'debug_bot': { 'debug_bot': {
'mixins': ['debug', 'reclient'], 'mixins': ['debug', 'reclient', 'strict_field_trials'],
}, },
'debug_static_bot': { 'debug_static_bot': {
'mixins': ['debug', 'minimal_symbols', 'reclient'], 'mixins': ['debug', 'minimal_symbols', 'reclient', 'strict_field_trials'],
}, },
'dummy_audio_file_devices': { 'dummy_audio_file_devices': {
'gn_args': 'rtc_use_dummy_audio_file_devices=true', 'gn_args': 'rtc_use_dummy_audio_file_devices=true',
@ -465,7 +465,7 @@
'gn_args': 'is_debug=false', 'gn_args': 'is_debug=false',
}, },
'release_bot': { 'release_bot': {
'mixins': ['pure_release_bot', 'dcheck_always_on'], 'mixins': ['pure_release_bot', 'dcheck_always_on', 'strict_field_trials'],
}, },
'rtc_objc_test_prefix': { 'rtc_objc_test_prefix': {
'gn_args': 'rtc_objc_prefix="RTC_TESTING"', 'gn_args': 'rtc_objc_prefix="RTC_TESTING"',
@ -473,6 +473,9 @@
'rtti': { 'rtti': {
'gn_args': 'use_rtti=true', 'gn_args': 'use_rtti=true',
}, },
'strict_field_trials': {
'gn_args': 'rtc_strict_field_trials="dcheck"',
},
'tsan': { 'tsan': {
'gn_args': 'is_tsan=true', 'gn_args': 'is_tsan=true',
}, },