From 3e560c6fb15c2296d31a24c327db66ab9c87babb Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Thu, 5 Oct 2023 13:38:51 +0000 Subject: [PATCH] Enable rtc_strict_field_trials DCHECKs on most of the bots. This will allow to stop CLs on CQ in case the CL is adding or removing a field trial without updating the field trial registry. This only affects debug and release bots but not pure_release bots since they are used for performance tests. Bug: webrtc:14154 Change-Id: Iab277fd4791b6f0cfb5304fd4e39a8519ea71198 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321880 Commit-Queue: Mirko Bonadei Auto-Submit: Mirko Bonadei Reviewed-by: Emil Lundmark Cr-Commit-Position: refs/heads/main@{#40877} --- tools_webrtc/mb/mb_config.pyl | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools_webrtc/mb/mb_config.pyl b/tools_webrtc/mb/mb_config.pyl index cb52f9124a..6aea3c9cba 100644 --- a/tools_webrtc/mb/mb_config.pyl +++ b/tools_webrtc/mb/mb_config.pyl @@ -397,10 +397,10 @@ 'gn_args': 'is_debug=true', }, 'debug_bot': { - 'mixins': ['debug', 'reclient'], + 'mixins': ['debug', 'reclient', 'strict_field_trials'], }, 'debug_static_bot': { - 'mixins': ['debug', 'minimal_symbols', 'reclient'], + 'mixins': ['debug', 'minimal_symbols', 'reclient', 'strict_field_trials'], }, 'dummy_audio_file_devices': { 'gn_args': 'rtc_use_dummy_audio_file_devices=true', @@ -465,7 +465,7 @@ 'gn_args': 'is_debug=false', }, 'release_bot': { - 'mixins': ['pure_release_bot', 'dcheck_always_on'], + 'mixins': ['pure_release_bot', 'dcheck_always_on', 'strict_field_trials'], }, 'rtc_objc_test_prefix': { 'gn_args': 'rtc_objc_prefix="RTC_TESTING"', @@ -473,6 +473,9 @@ 'rtti': { 'gn_args': 'use_rtti=true', }, + 'strict_field_trials': { + 'gn_args': 'rtc_strict_field_trials="dcheck"', + }, 'tsan': { 'gn_args': 'is_tsan=true', },