admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove Chromium Clang warnings only on Windows.

Browse Source 
A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they hadn't been set.

This CL fixes it suppressing warnings only on Windows.

Example failures:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/6540
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/16588
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/9655

BUG=webrtc:6255
NOTRY=True

Review-Url: https://codereview.webrtc.org/2284333002
Cr-Commit-Position: refs/heads/master@{#13951}
This commit is contained in:
ehmaldonado 2016-08-29 02:56:06 -07:00 committed by Commit bot
parent 1b365a8db0
commit 3e3b6f2805
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/base/BUILD.gn
View File

@ -668,7 +668,7 @@ static_library("rtc_base") {
defines += [ "timezone=_timezone" ]
sources -= [ "ifaddrs_converter.cc" ]
}
if (is_clang) {
if (is_win && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
configs -= [ "//build/config/clang:find_bad_constructs" ]
}

2
webrtc/system_wrappers/BUILD.gn
View File

@ -133,7 +133,7 @@ source_set("system_wrappers") {
cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion.
}
if (is_clang) {
if (is_win && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
configs -= [ "//build/config/clang:find_bad_constructs" ]
}