From 3e3b6f2805d34f824b2606720273d96f5b7b5cc9 Mon Sep 17 00:00:00 2001 From: ehmaldonado Date: Mon, 29 Aug 2016 02:56:06 -0700 Subject: [PATCH] Remove Chromium Clang warnings only on Windows. A previous CL (https://codereview.webrtc.org/2281513002) broke Windows, Mac and Linux bots in WebRTC's Chromium FYI, by suppressing these warnings when they hadn't been set. This CL fixes it suppressing warnings only on Windows. Example failures: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/6540 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/16588 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/9655 BUG=webrtc:6255 NOTRY=True Review-Url: https://codereview.webrtc.org/2284333002 Cr-Commit-Position: refs/heads/master@{#13951} --- webrtc/base/BUILD.gn | 2 +- webrtc/system_wrappers/BUILD.gn | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn index a1748cadc4..9d4aa4c8fb 100644 --- a/webrtc/base/BUILD.gn +++ b/webrtc/base/BUILD.gn @@ -668,7 +668,7 @@ static_library("rtc_base") { defines += [ "timezone=_timezone" ] sources -= [ "ifaddrs_converter.cc" ] } - if (is_clang) { + if (is_win && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). configs -= [ "//build/config/clang:find_bad_constructs" ] } diff --git a/webrtc/system_wrappers/BUILD.gn b/webrtc/system_wrappers/BUILD.gn index 826113dae4..8126f506bb 100644 --- a/webrtc/system_wrappers/BUILD.gn +++ b/webrtc/system_wrappers/BUILD.gn @@ -133,7 +133,7 @@ source_set("system_wrappers") { cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion. } - if (is_clang) { + if (is_win && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). configs -= [ "//build/config/clang:find_bad_constructs" ] }