admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changing some PeerConnection-related comments.

Browse Source 
As recommended by nisse@ in comments on this CL:
https://codereview.webrtc.org/2685093002/

BUG=None
NOTRY=True
TBR=nisse@webrtc.org

Review-Url: https://codereview.webrtc.org/2692923002
Cr-Commit-Position: refs/heads/master@{#16589}
This commit is contained in:
deadbeef 2017-02-13 09:49:58 -08:00 committed by Commit bot
parent e3a5567230
commit 39e14da919
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/api/peerconnectioninterface.h
View File

@ -965,8 +965,11 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {
virtual rtc::scoped_refptr<AudioSourceInterface> CreateAudioSource(
const MediaConstraintsInterface* constraints) = 0;
// Creates a VideoTrackSourceInterface. The new source takes ownership of
// |capturer|.
// Creates a VideoTrackSourceInterface from |capturer|.
// TODO(deadbeef): We should aim to remove cricket::VideoCapturer from the
// API. It's mainly used as a wrapper around webrtc's provided
// platform-specific capturers, but these should be refactored to use
// VideoTrackSourceInterface directly.
// TODO(deadbeef): Make pure virtual once downstream mock PC factory classes
// are updated.
virtual rtc::scoped_refptr<VideoTrackSourceInterface> CreateVideoSource(

2
webrtc/pc/peerconnectionfactory.cc
View File

@ -209,8 +209,6 @@ bool PeerConnectionFactory::Initialize() {
return false;
}
// TODO: Need to make sure only one VoE is created inside
// WebRtcMediaEngine.
std::unique_ptr<cricket::MediaEngineInterface> media_engine =
worker_thread_->Invoke<std::unique_ptr<cricket::MediaEngineInterface>>(
RTC_FROM_HERE,

3
webrtc/pc/videocapturertracksource.h
View File

@ -33,8 +33,7 @@ class MediaConstraintsInterface;
class VideoCapturerTrackSource : public VideoTrackSource,
public sigslot::has_slots<> {
public:
// Creates an instance of VideoCapturerTrackSource.
// VideoCapturerTrackSource takes ownership of |capturer|.
// Creates an instance of VideoCapturerTrackSource from |capturer|.
// |constraints| can be NULL and in that case the camera is opened using a
// default resolution.
static rtc::scoped_refptr<VideoTrackSourceInterface> Create(