From 39e14da919415793acf6a26787965a847a936dcb Mon Sep 17 00:00:00 2001 From: deadbeef Date: Mon, 13 Feb 2017 09:49:58 -0800 Subject: [PATCH] Changing some PeerConnection-related comments. As recommended by nisse@ in comments on this CL: https://codereview.webrtc.org/2685093002/ BUG=None NOTRY=True TBR=nisse@webrtc.org Review-Url: https://codereview.webrtc.org/2692923002 Cr-Commit-Position: refs/heads/master@{#16589} --- webrtc/api/peerconnectioninterface.h | 7 +++++-- webrtc/pc/peerconnectionfactory.cc | 2 -- webrtc/pc/videocapturertracksource.h | 3 +-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h index 0c9198cd01..950dad8f0b 100644 --- a/webrtc/api/peerconnectioninterface.h +++ b/webrtc/api/peerconnectioninterface.h @@ -965,8 +965,11 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface { virtual rtc::scoped_refptr CreateAudioSource( const MediaConstraintsInterface* constraints) = 0; - // Creates a VideoTrackSourceInterface. The new source takes ownership of - // |capturer|. + // Creates a VideoTrackSourceInterface from |capturer|. + // TODO(deadbeef): We should aim to remove cricket::VideoCapturer from the + // API. It's mainly used as a wrapper around webrtc's provided + // platform-specific capturers, but these should be refactored to use + // VideoTrackSourceInterface directly. // TODO(deadbeef): Make pure virtual once downstream mock PC factory classes // are updated. virtual rtc::scoped_refptr CreateVideoSource( diff --git a/webrtc/pc/peerconnectionfactory.cc b/webrtc/pc/peerconnectionfactory.cc index 743f51702c..74a693d240 100644 --- a/webrtc/pc/peerconnectionfactory.cc +++ b/webrtc/pc/peerconnectionfactory.cc @@ -209,8 +209,6 @@ bool PeerConnectionFactory::Initialize() { return false; } - // TODO: Need to make sure only one VoE is created inside - // WebRtcMediaEngine. std::unique_ptr media_engine = worker_thread_->Invoke>( RTC_FROM_HERE, diff --git a/webrtc/pc/videocapturertracksource.h b/webrtc/pc/videocapturertracksource.h index af87cc9b82..1a2529b1b6 100644 --- a/webrtc/pc/videocapturertracksource.h +++ b/webrtc/pc/videocapturertracksource.h @@ -33,8 +33,7 @@ class MediaConstraintsInterface; class VideoCapturerTrackSource : public VideoTrackSource, public sigslot::has_slots<> { public: - // Creates an instance of VideoCapturerTrackSource. - // VideoCapturerTrackSource takes ownership of |capturer|. + // Creates an instance of VideoCapturerTrackSource from |capturer|. // |constraints| can be NULL and in that case the camera is opened using a // default resolution. static rtc::scoped_refptr Create(