admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable more flaky PeerConnectionIntegrationTests on Windows

Browse Source 
Bug: webrtc:12590, webrtc:12591
Change-Id: Id7703d6eb0c898789fa99216635578d5cf188c74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212085
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33490}
This commit is contained in:
Rasmus Brandt 2021-03-17 13:40:21 +01:00 committed by Commit Bot
parent cf93670a27
commit 32af25b72a
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pc/peer_connection_integrationtest.cc
View File

@ -1866,8 +1866,16 @@ constexpr int kOnlyLocalPorts = cricket::PORTALLOCATOR_DISABLE_STUN |
// Use a mock resolver to resolve the hostname back to the original IP on both
// sides and check that the ICE connection connects.
// TODO(bugs.webrtc.org/12590): Flaky on Windows.
#if defined(WEBRTC_WIN)
#define MAYBE_IceStatesReachCompletionWithRemoteHostname \
DISABLED_IceStatesReachCompletionWithRemoteHostname
#else
#define MAYBE_IceStatesReachCompletionWithRemoteHostname \
IceStatesReachCompletionWithRemoteHostname
#endif
TEST_P(PeerConnectionIntegrationTest,
IceStatesReachCompletionWithRemoteHostname) {
MAYBE_IceStatesReachCompletionWithRemoteHostname) {
auto caller_resolver_factory =
std::make_unique<NiceMock<webrtc::MockAsyncResolverFactory>>();
auto callee_resolver_factory =
@ -2123,7 +2131,13 @@ TEST_P(PeerConnectionIntegrationIceStatesTestWithFakeClock,
// Tests that the best connection is set to the appropriate IPv4/IPv6 connection
// and that the statistics in the metric observers are updated correctly.
TEST_P(PeerConnectionIntegrationIceStatesTest, VerifyBestConnection) {
// TODO(bugs.webrtc.org/12591): Flaky on Windows.
#if defined(WEBRTC_WIN)
#define MAYBE_VerifyBestConnection DISABLED_VerifyBestConnection
#else
#define MAYBE_VerifyBestConnection VerifyBestConnection
#endif
TEST_P(PeerConnectionIntegrationIceStatesTest, MAYBE_VerifyBestConnection) {
ASSERT_TRUE(CreatePeerConnectionWrappers());
ConnectFakeSignaling();
SetPortAllocatorFlags();