From 32af25b72ad4ad866d3b88dae222ea829c326380 Mon Sep 17 00:00:00 2001 From: Rasmus Brandt Date: Wed, 17 Mar 2021 13:40:21 +0100 Subject: [PATCH] Disable more flaky PeerConnectionIntegrationTests on Windows Bug: webrtc:12590, webrtc:12591 Change-Id: Id7703d6eb0c898789fa99216635578d5cf188c74 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212085 Reviewed-by: Harald Alvestrand Commit-Queue: Rasmus Brandt Cr-Commit-Position: refs/heads/master@{#33490} --- pc/peer_connection_integrationtest.cc | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/pc/peer_connection_integrationtest.cc b/pc/peer_connection_integrationtest.cc index 112826cf0a..76cfb48e00 100644 --- a/pc/peer_connection_integrationtest.cc +++ b/pc/peer_connection_integrationtest.cc @@ -1866,8 +1866,16 @@ constexpr int kOnlyLocalPorts = cricket::PORTALLOCATOR_DISABLE_STUN | // Use a mock resolver to resolve the hostname back to the original IP on both // sides and check that the ICE connection connects. +// TODO(bugs.webrtc.org/12590): Flaky on Windows. +#if defined(WEBRTC_WIN) +#define MAYBE_IceStatesReachCompletionWithRemoteHostname \ + DISABLED_IceStatesReachCompletionWithRemoteHostname +#else +#define MAYBE_IceStatesReachCompletionWithRemoteHostname \ + IceStatesReachCompletionWithRemoteHostname +#endif TEST_P(PeerConnectionIntegrationTest, - IceStatesReachCompletionWithRemoteHostname) { + MAYBE_IceStatesReachCompletionWithRemoteHostname) { auto caller_resolver_factory = std::make_unique>(); auto callee_resolver_factory = @@ -2123,7 +2131,13 @@ TEST_P(PeerConnectionIntegrationIceStatesTestWithFakeClock, // Tests that the best connection is set to the appropriate IPv4/IPv6 connection // and that the statistics in the metric observers are updated correctly. -TEST_P(PeerConnectionIntegrationIceStatesTest, VerifyBestConnection) { +// TODO(bugs.webrtc.org/12591): Flaky on Windows. +#if defined(WEBRTC_WIN) +#define MAYBE_VerifyBestConnection DISABLED_VerifyBestConnection +#else +#define MAYBE_VerifyBestConnection VerifyBestConnection +#endif +TEST_P(PeerConnectionIntegrationIceStatesTest, MAYBE_VerifyBestConnection) { ASSERT_TRUE(CreatePeerConnectionWrappers()); ConnectFakeSignaling(); SetPortAllocatorFlags();