admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't fail SetStereoPlayout(false) for Android devices.

Browse Source 
It isn't implemented, but failing produces warning messages in logs
from code that just does the equivalent of:
SetStereoPlayout(StereoPlayoutIsAvailable)

BUG=none

Specifically:
https://cs.chromium.org/chromium/src/third_party/webrtc/voice_engine/voe_base_impl.cc?l=323

Change-Id: Iad1b026d903bbab74923db35bde50054f125d84b
Reviewed-on: https://chromium-review.googlesource.com/612218
Reviewed-by: Henrik Andreasson <henrika@webrtc.org>
Commit-Queue: Henrik Andreasson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19365}
This commit is contained in:
Noah Richards 2017-08-11 13:27:46 -07:00 committed by Commit Bot
parent 7fbeb0b3c9
commit 3004fd0888
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/modules/audio_device/android/audio_device_template.h
View File

@ -377,7 +377,9 @@ class AudioDeviceTemplate : public AudioDeviceGeneric {
// TODO(henrika): add support.
int32_t SetStereoPlayout(bool enable) override {
LOG(INFO) << __FUNCTION__;
return -1;
// Allow disabling stereo playout, as that matches returning false(0) from
// StereoPlayoutIsAvailable and is the default case.
return enable ? -1 : 0;
}
// TODO(henrika): add support.