From 3004fd088812e7d0879af45d50f19631ec9bf743 Mon Sep 17 00:00:00 2001 From: Noah Richards Date: Fri, 11 Aug 2017 13:27:46 -0700 Subject: [PATCH] Don't fail SetStereoPlayout(false) for Android devices. It isn't implemented, but failing produces warning messages in logs from code that just does the equivalent of: SetStereoPlayout(StereoPlayoutIsAvailable) BUG=none Specifically: https://cs.chromium.org/chromium/src/third_party/webrtc/voice_engine/voe_base_impl.cc?l=323 Change-Id: Iad1b026d903bbab74923db35bde50054f125d84b Reviewed-on: https://chromium-review.googlesource.com/612218 Reviewed-by: Henrik Andreasson Commit-Queue: Henrik Andreasson Cr-Commit-Position: refs/heads/master@{#19365} --- webrtc/modules/audio_device/android/audio_device_template.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/webrtc/modules/audio_device/android/audio_device_template.h b/webrtc/modules/audio_device/android/audio_device_template.h index 52107cc8b7..72e008c4e0 100644 --- a/webrtc/modules/audio_device/android/audio_device_template.h +++ b/webrtc/modules/audio_device/android/audio_device_template.h @@ -377,7 +377,9 @@ class AudioDeviceTemplate : public AudioDeviceGeneric { // TODO(henrika): add support. int32_t SetStereoPlayout(bool enable) override { LOG(INFO) << __FUNCTION__; - return -1; + // Allow disabling stereo playout, as that matches returning false(0) from + // StereoPlayoutIsAvailable and is the default case. + return enable ? -1 : 0; } // TODO(henrika): add support.