admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove spammy logging of RTCP delivery failures.

Browse Source 
Since BundleFilter doesn't filter RTCP anymore we can have incoming
RTCPs for audio delivered to video, that delivery will fail when there
are no video receivers causing the log to be spammed.

BUG=webrtc:5223
R=henrika@webrtc.org

Review URL: https://codereview.webrtc.org/1458853002 .

Cr-Commit-Position: refs/heads/master@{#10687}
This commit is contained in:
Peter Boström 2015-11-18 13:47:16 +01:00
parent f70568c04b
commit 2aff615bd7
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
talk/media/webrtc/webrtcvideoengine2.cc
View File

@ -1478,12 +1478,14 @@ void WebRtcVideoChannel2::OnRtcpReceived(
const rtc::PacketTime& packet_time) {
const webrtc::PacketTime webrtc_packet_time(packet_time.timestamp,
packet_time.not_before);
if (call_->Receiver()->DeliverPacket(
webrtc::MediaType::VIDEO,
reinterpret_cast<const uint8_t*>(packet->data()), packet->size(),
webrtc_packet_time) != webrtc::PacketReceiver::DELIVERY_OK) {
LOG(LS_WARNING) << "Failed to deliver RTCP packet.";
}
// TODO(pbos): Check webrtc::PacketReceiver::DELIVERY_OK once we deliver
// for both audio and video on the same path. Since BundleFilter doesn't
// filter RTCP anymore incoming RTCP packets could've been going to audio (so
// logging failures spam the log).
call_->Receiver()->DeliverPacket(
webrtc::MediaType::VIDEO,
reinterpret_cast<const uint8_t*>(packet->data()), packet->size(),
webrtc_packet_time);
}
void WebRtcVideoChannel2::OnReadyToSend(bool ready) {