From 2aff615bd7c7c24a6e7a35163112f169ff4f9246 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Bostr=C3=B6m?= Date: Wed, 18 Nov 2015 13:47:16 +0100 Subject: [PATCH] Remove spammy logging of RTCP delivery failures. Since BundleFilter doesn't filter RTCP anymore we can have incoming RTCPs for audio delivered to video, that delivery will fail when there are no video receivers causing the log to be spammed. BUG=webrtc:5223 R=henrika@webrtc.org Review URL: https://codereview.webrtc.org/1458853002 . Cr-Commit-Position: refs/heads/master@{#10687} --- talk/media/webrtc/webrtcvideoengine2.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc index 101ed15bdd..0f1587d54f 100644 --- a/talk/media/webrtc/webrtcvideoengine2.cc +++ b/talk/media/webrtc/webrtcvideoengine2.cc @@ -1478,12 +1478,14 @@ void WebRtcVideoChannel2::OnRtcpReceived( const rtc::PacketTime& packet_time) { const webrtc::PacketTime webrtc_packet_time(packet_time.timestamp, packet_time.not_before); - if (call_->Receiver()->DeliverPacket( - webrtc::MediaType::VIDEO, - reinterpret_cast(packet->data()), packet->size(), - webrtc_packet_time) != webrtc::PacketReceiver::DELIVERY_OK) { - LOG(LS_WARNING) << "Failed to deliver RTCP packet."; - } + // TODO(pbos): Check webrtc::PacketReceiver::DELIVERY_OK once we deliver + // for both audio and video on the same path. Since BundleFilter doesn't + // filter RTCP anymore incoming RTCP packets could've been going to audio (so + // logging failures spam the log). + call_->Receiver()->DeliverPacket( + webrtc::MediaType::VIDEO, + reinterpret_cast(packet->data()), packet->size(), + webrtc_packet_time); } void WebRtcVideoChannel2::OnReadyToSend(bool ready) {