admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Report all usage patterns to UKM

Browse Source 
This stores usage for all cases, making it easier to discover
abusive usages on unexpected patterns.

Bug: None
Change-Id: I62c9b07498e811ac04c221f57cfbc02312aaaacc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368902
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43442}
This commit is contained in:
Harald Alvestrand 2024-11-22 10:04:05 +00:00 committed by WebRTC LUCI CQ
parent 394da76a9c
commit 24992e9518
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
pc/usage_pattern.cc
View File

@ -25,24 +25,14 @@ void UsagePattern::ReportUsagePattern(PeerConnectionObserver* observer) const {
RTC_HISTOGRAM_ENUMERATION_SPARSE("WebRTC.PeerConnection.UsagePattern", RTC_HISTOGRAM_ENUMERATION_SPARSE("WebRTC.PeerConnection.UsagePattern",
usage_event_accumulator_, usage_event_accumulator_,
static_cast<int>(UsageEvent::MAX_VALUE)); static_cast<int>(UsageEvent::MAX_VALUE));
const int bad_bits = // If called after close(), we can't report, because observer may have
static_cast<int>(UsageEvent::SET_LOCAL_DESCRIPTION_SUCCEEDED) | // been deallocated, and therefore pointer is null. Write to log instead.
static_cast<int>(UsageEvent::CANDIDATE_COLLECTED); if (observer) {
const int good_bits = observer->OnInterestingUsage(usage_event_accumulator_);
static_cast<int>(UsageEvent::SET_REMOTE_DESCRIPTION_SUCCEEDED) | } else {
static_cast<int>(UsageEvent::REMOTE_CANDIDATE_ADDED) | RTC_LOG(LS_INFO) << "Interesting usage signature "
static_cast<int>(UsageEvent::ICE_STATE_CONNECTED); << usage_event_accumulator_
if ((usage_event_accumulator_ & bad_bits) == bad_bits && << " observed after observer shutdown";
(usage_event_accumulator_ & good_bits) == 0) {
// If called after close(), we can't report, because observer may have
// been deallocated, and therefore pointer is null. Write to log instead.
if (observer) {
observer->OnInterestingUsage(usage_event_accumulator_);
} else {
RTC_LOG(LS_INFO) << "Interesting usage signature "
<< usage_event_accumulator_
<< " observed after observer shutdown";
}
} }
} }