From 24992e95183d4c5a853b6e791485851a0cf55cbd Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Fri, 22 Nov 2024 10:04:05 +0000 Subject: [PATCH] Report all usage patterns to UKM This stores usage for all cases, making it easier to discover abusive usages on unexpected patterns. Bug: None Change-Id: I62c9b07498e811ac04c221f57cfbc02312aaaacc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368902 Commit-Queue: Harald Alvestrand Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#43442} --- pc/usage_pattern.cc | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/pc/usage_pattern.cc b/pc/usage_pattern.cc index 848472148f..e96a3943a5 100644 --- a/pc/usage_pattern.cc +++ b/pc/usage_pattern.cc @@ -25,24 +25,14 @@ void UsagePattern::ReportUsagePattern(PeerConnectionObserver* observer) const { RTC_HISTOGRAM_ENUMERATION_SPARSE("WebRTC.PeerConnection.UsagePattern", usage_event_accumulator_, static_cast(UsageEvent::MAX_VALUE)); - const int bad_bits = - static_cast(UsageEvent::SET_LOCAL_DESCRIPTION_SUCCEEDED) | - static_cast(UsageEvent::CANDIDATE_COLLECTED); - const int good_bits = - static_cast(UsageEvent::SET_REMOTE_DESCRIPTION_SUCCEEDED) | - static_cast(UsageEvent::REMOTE_CANDIDATE_ADDED) | - static_cast(UsageEvent::ICE_STATE_CONNECTED); - if ((usage_event_accumulator_ & bad_bits) == bad_bits && - (usage_event_accumulator_ & good_bits) == 0) { - // If called after close(), we can't report, because observer may have - // been deallocated, and therefore pointer is null. Write to log instead. - if (observer) { - observer->OnInterestingUsage(usage_event_accumulator_); - } else { - RTC_LOG(LS_INFO) << "Interesting usage signature " - << usage_event_accumulator_ - << " observed after observer shutdown"; - } + // If called after close(), we can't report, because observer may have + // been deallocated, and therefore pointer is null. Write to log instead. + if (observer) { + observer->OnInterestingUsage(usage_event_accumulator_); + } else { + RTC_LOG(LS_INFO) << "Interesting usage signature " + << usage_event_accumulator_ + << " observed after observer shutdown"; } }