Update comments on SendSideCongestionController::RegisterNetworkObserver

Tbr: stefan@webrtc.org
Bug: None
Change-Id: I9407004c3f6ac3549e1df056a42ed735055960a5
Reviewed-on: https://webrtc-review.googlesource.com/20875
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20596}
This commit is contained in:
Niels Möller 2017-11-07 15:00:48 +01:00 committed by Commit Bot
parent 5c24c67fd2
commit 2416f894f5

View File

@ -57,8 +57,6 @@ class SendSideCongestionController : public CallStatsObserver,
protected:
virtual ~Observer() {}
};
// TODO(nisse): Consider deleting the |observer| argument to constructors
// once CongestionController is deleted.
SendSideCongestionController(const Clock* clock,
Observer* observer,
RtcEventLog* event_log,
@ -69,6 +67,11 @@ class SendSideCongestionController : public CallStatsObserver,
void DeRegisterPacketFeedbackObserver(PacketFeedbackObserver* observer);
// Currently, there can be at most one observer.
// TODO(nisse): The RegisterNetworkObserver method is needed because we first
// construct this object (as part of RtpTransportControllerSend), then pass a
// reference to Call, which then registers itself as the observer. We should
// try to break this circular chain of references, and make the observer a
// construction time constant.
void RegisterNetworkObserver(Observer* observer);
void DeRegisterNetworkObserver(Observer* observer);