From 2416f894f520671ee62f90fdc2f6ad0a38221860 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Tue, 7 Nov 2017 15:00:48 +0100 Subject: [PATCH] Update comments on SendSideCongestionController::RegisterNetworkObserver Tbr: stefan@webrtc.org Bug: None Change-Id: I9407004c3f6ac3549e1df056a42ed735055960a5 Reviewed-on: https://webrtc-review.googlesource.com/20875 Commit-Queue: Niels Moller Reviewed-by: Danil Chapovalov Cr-Commit-Position: refs/heads/master@{#20596} --- .../include/send_side_congestion_controller.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/modules/congestion_controller/include/send_side_congestion_controller.h b/modules/congestion_controller/include/send_side_congestion_controller.h index 8e56aed778..e3e081c101 100644 --- a/modules/congestion_controller/include/send_side_congestion_controller.h +++ b/modules/congestion_controller/include/send_side_congestion_controller.h @@ -57,8 +57,6 @@ class SendSideCongestionController : public CallStatsObserver, protected: virtual ~Observer() {} }; - // TODO(nisse): Consider deleting the |observer| argument to constructors - // once CongestionController is deleted. SendSideCongestionController(const Clock* clock, Observer* observer, RtcEventLog* event_log, @@ -69,6 +67,11 @@ class SendSideCongestionController : public CallStatsObserver, void DeRegisterPacketFeedbackObserver(PacketFeedbackObserver* observer); // Currently, there can be at most one observer. + // TODO(nisse): The RegisterNetworkObserver method is needed because we first + // construct this object (as part of RtpTransportControllerSend), then pass a + // reference to Call, which then registers itself as the observer. We should + // try to break this circular chain of references, and make the observer a + // construction time constant. void RegisterNetworkObserver(Observer* observer); void DeRegisterNetworkObserver(Observer* observer);