admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bug in use_datagram_transport configuration.

Browse Source 
Currently, use_datagram_transport's non-default value is never used.
Instead of reading configuration.use_datagram_transport,
PeerConnection::Initialize reads the local configuration's
use_datagram_transport.  This hasn't been set yet, and so it always
falls back to the default value.

Bug: webrtc:9719
Change-Id: I028ed537c7d88ee3421b6bd92fc7d5e3c6970529
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144441
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28451}
This commit is contained in:
Bjorn A Mellem 2019-07-02 11:06:00 -07:00 committed by Commit Bot
parent b073f1c27f
commit 238aab9948
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pc/peer_connection.cc
View File

@ -1034,7 +1034,7 @@ bool PeerConnection::Initialize(
config.active_reset_srtp_params = configuration.active_reset_srtp_params;
use_datagram_transport_ = datagram_transport_config_.enabled &&
configuration_.use_datagram_transport.value_or(
configuration.use_datagram_transport.value_or(
datagram_transport_config_.default_value);
if (use_datagram_transport_ || configuration.use_media_transport ||
configuration.use_media_transport_for_data_channels) {